feat: added update password command
#255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baalekshan
requested review from
Jonsy13,
Saranya-jena and
SarthakJain26
as code owners
pkg/cmd/update/password.go
Outdated
| ) | ||
|
|
||
| credentials, err := utils.GetCredentials(cmd) | ||
| utils.PrintError(err) |
There was a problem hiding this comment.
Suggested change
| utils.PrintError(err) | |
| if err != nil { | |
| utils.PrintError(err) | |
| } | |
pkg/cmd/update/password.go
Outdated
| Label: "Username", | ||
| } | ||
| updatePasswordRequest.Username, err = promptUsername.Run() | ||
| utils.PrintError(err) |
There was a problem hiding this comment.
Same as above, please check if err != nil condition wherever printing err. Please update in all other places
| updatePasswordRequest.OldPassword, err = promptOldPassword.Run() | ||
| utils.PrintError(err) | ||
|
|
||
| NEW_PASSWORD: |
There was a problem hiding this comment.
Instead of this, you can just add comment
// New password validation
There was a problem hiding this comment.
@SarthakJain26 It was for a goto condition
if the new and confirm passwords fails, it agains runs the code under NEW_PASSWORD:
instead of the user requiring to rerun the command again
Signed-off-by: Baalekshan <[email protected]>
Signed-off-by: Baalekshan <[email protected]>
Signed-off-by: Baalekshan <[email protected]>
Signed-off-by: Baalekshan <[email protected]>
Jonsy13
approved these changes
Sep 17, 2024
Signed-off-by: Baalekshan <[email protected]>
SarthakJain26
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
### Description:
Introduced
litmusctl update passwordcommand,User can now update their passwords using litmusctl