Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake build #9

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Cmake build #9

wants to merge 12 commits into from

Conversation

Mezozoysky
Copy link

@Mezozoysky Mezozoysky commented Dec 15, 2022

Hi!
These days CMake became a de-facto standard for building and distributing C/C++ projects. Also, like most C++ programmers, i hate autotools/automake and don't know anyone who uses clib in their development (not going to offend clib).
So i've add CMake build support for SOIL.

Cons:

  • clib and automake builds are probably slightly broken because of moving compile defs from actually compile defs to CMake-configured header file (passing string defs to compiler is broken on Windows).

Pros:

  • it's possible to build/install SOIL as static or shared libs and easlily discover with CMake
  • it works for *nix, Windows and Android (i personally use it for Android project) and will work (after i get mac device :) ) on iOs.
  • it's able to provide custom headers/libraries to SOIL build (needed since we have amount of different OpenGL versions these days)
  • doxygen documentation autogenerates while building if doxygen installed

Also i've added names to enums in SOIL.h just to slightly improve autodocs generation.

Thanx for your attention and criticism :)

@Mezozoysky Mezozoysky marked this pull request as draft December 15, 2022 18:29
@Mezozoysky Mezozoysky marked this pull request as ready for review December 15, 2022 18:30

#ifdef _WIN32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's moved into SOIL_GL.h.in

@jwerle
Copy link
Contributor

jwerle commented Dec 16, 2022

unfortunately, I no longer have control of this repository so someone from littlstar will have to review, and merge. This repository should probably be archived as anyone who would maintain is no longer able to

@Mezozoysky
Copy link
Author

Understood.
Thank You.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants