Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add features to localize Welcome-Guide and Telemetry-Consent #320

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

juggernautjp
Copy link
Contributor

Requirements for Contributing a Bug Fix

This fix enable atom-i18n to localize "Welcome Guide" and "Telemetry Consent" views.

Identify the Bug

atom-i18n can not localize both "Welcome Guide" and "Telemetry Consent" views.

Those bugs are opened as the Issue #319.

Description of the Change

  • add feature of localizing 'Welcome Guide' and 'Telemetry Consent' (so, you can localize them)
    • add 'consent.cson' and 'guide.cson' file to def/{template, }/ directory
    • localize 'consent.cson' and 'guide.cson' file in Japanese
    • add 'consent.cson' and 'guide.cson' specification to spec/config.js file
    • change def/*/welcome.cson from json format to cson format
    • add lib/{consent, guide}.js, and fix a minor bug of lib/welcome.js
  • Also, end-of-line code of all files that are modified, are 'CRLF' (Windows format)
  • The branch is add/localize-welcome-views

Alternate Designs

None

Possible Drawbacks

User might not be be able to change telemetry consent settings.

Verification Process

  1. All locale files, such as def/ja/welcome.cson, are tested with npm run validation -- --locale.
  2. All locale files are tested on Atom editor with atom-i18n, by manually changing locale.

Release Notes

  • "Welcome Guide" and "Telemetry Consent" are able to be localized in your language.

This fix enable to localize Welcome-Guide and Telemetry-Consent views, and fix some minor bug of Welcome view.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants