Fix bug of not localize Menu and Context-Menu #322
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing a Bug Fix
This fix enable
atom-i18n
to localize "Welcome Guide" and "Telemetry Consent" views.Identify the Bug
atom-i18n
can not localize "Packages" menu, GitHub menus in "View" and "Context Menu.The above bugs are opened as the following:
Description of the Change
def/*/context.cson
anddef/*/menu_{darwin, linux, win32}.cson
def/ja/*.cson
fix/not-localize-menus
Alternate Designs
None
Possible Drawbacks
None, I think.
Verification Process
def/ja/context.cson
, are tested withnpm run validation -- --locale
.atom-i18n
, by manually changing locale.Release Notes