Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug of not localize Menu and Context-Menu #322

Merged
merged 1 commit into from
Jul 3, 2021

Conversation

juggernautjp
Copy link
Contributor

Requirements for Contributing a Bug Fix

This fix enable atom-i18n to localize "Welcome Guide" and "Telemetry Consent" views.

Identify the Bug

atom-i18n can not localize "Packages" menu, GitHub menus in "View" and "Context Menu.

The above bugs are opened as the following:

  1. Issue #299
  2. Issue #321

Description of the Change

  • add feature of localizing 'Packages' menu for Atom Core Packages, which is bundled at the release.
  • modify the existing files of def/*/context.cson and def/*/menu_{darwin, linux, win32}.cson
  • localize all strings to Japanese in def/ja/*.cson
  • Also, end-of-line code of all files that are modified, are 'CRLF' (Windows format)
  • The branch is fix/not-localize-menus

Alternate Designs

None

Possible Drawbacks

None, I think.

Verification Process

  1. All locale files, such as def/ja/context.cson, are tested with npm run validation -- --locale.
  2. All locale files are tested on Atom editor with atom-i18n, by manually changing locale.

Release Notes

  • All Menu and Context Menu are able to be localized in your language.

Add strings of "Atom Core Packages" menus
Copy link
Owner

@liuderchi liuderchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juggernautjp Thank you so much for such a great contribution! 🙇‍♂️

@liuderchi liuderchi merged commit a44008e into liuderchi:main Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants