Add docker deployment instructions to app panel #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatanklosko
force-pushed
the
jk-app-docker
branch
from
8a91c8b to
0f379ad
Compare
|
Uffizzi Preview |
|
Two initial nitpicks:
|
josevalim
reviewed
Oct 16, 2023
josevalim
reviewed
Oct 16, 2023
josevalim
reviewed
Oct 16, 2023
josevalim
reviewed
Oct 16, 2023
The warnings are just string messages, but I guess we can inline the link and use |
jonatanklosko
force-pushed
the
jk-app-docker
branch
from
1d853f0 to
81d5e9b
Compare
jonatanklosko
force-pushed
the
jk-app-docker
branch
from
90c8561 to
89d3a7a
Compare
|
Updated and added tests for the warnings :) |
josevalim
approved these changes
Oct 17, 2023
|
💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
that referenced
this pull request
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds configurable instructions for Docker deployment with both personal and teams hub. Also unifies it with the instructions we have on the teams hub page.
Personal
Teams