New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(web): slice instead of substring #13

Open

jjangga0214 wants to merge 1 commit into livekit-examples:main from jjangga0214:refactor/web/slice-over-substring

Contributor

jjangga0214 commented Oct 10, 2024 •

edited

Loading

This is not required, but a good convention across the ecosystem.

For example,

Ref: https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v49.0.0/docs/rules/prefer-string-slice.md

String#substr() and String#substring() are the two lesser known legacy ways to slice a string. It's better to use String#slice() as it's a more popular option with clearer behavior that has a consistent Array counterpart.


          refactor(web): slice instead of substring

b3195be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet