Fix state handling issue in SignalClient (#1004)

* Fix state handling issue in SignalClient * Create tall-files-shop.md --------- Co-authored-by: lukasIO <[email protected]>
livekit · Jan 24, 2024 · bb0a1d3 · bb0a1d3
1 parent 24a8d6e
commit bb0a1d3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/.changeset/tall-files-shop.md b/.changeset/tall-files-shop.md
@@ -0,0 +1,5 @@
+---
+"livekit-client": patch
+---
+
+Fix state handling issue in SignalClient
diff --git a/src/api/SignalClient.ts b/src/api/SignalClient.ts
@@ -272,7 +272,7 @@ export class SignalClient {
         abortSignal?.addEventListener('abort', abortHandler);
         this.log.debug(`connecting to ${url + params}`, this.logContext);
         if (this.ws) {
-          await this.close();
+          await this.close(false);
         }
         this.ws = new WebSocket(url + params);
         this.ws.binaryType = 'arraybuffer';
@@ -421,10 +421,12 @@ export class SignalClient {
     this.onClose = undefined;
   };
 
-  async close() {
+  async close(updateState: boolean = true) {
     const unlock = await this.closingLock.lock();
     try {
-      this.state = SignalConnectionState.DISCONNECTING;
+      if (updateState) {
+        this.state = SignalConnectionState.DISCONNECTING;
+      }
       if (this.ws) {
         this.ws.onmessage = null;
         this.ws.onopen = null;
@@ -449,7 +451,9 @@ export class SignalClient {
         this.ws = undefined;
       }
     } finally {
-      this.state = SignalConnectionState.DISCONNECTED;
+      if (updateState) {
+        this.state = SignalConnectionState.DISCONNECTED;
+      }
       this.clearPingInterval();
       unlock();
     }