Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 893: broken livekit-client in Angular #901

Merged
merged 4 commits into from
Oct 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tough-shirts-fold.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"livekit-client": patch
---

Fix Typescript compilation error in angular setups
2 changes: 1 addition & 1 deletion src/room/track/LocalAudioTrack.ts
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ export default class LocalAudioTrack extends LocalTrack {
this.prevStats = stats;
};

async setProcessor(processor: TrackProcessor<typeof this.kind>) {
async setProcessor(processor: TrackProcessor<this['kind']>) {
const unlock = await this.processorLock.lock();
try {
if (!this.audioContext) {
Expand Down
7 changes: 2 additions & 5 deletions src/room/track/LocalTrack.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export default abstract class LocalTrack extends Track {

protected processorElement?: HTMLMediaElement;

protected processor?: TrackProcessor<typeof this.kind>;
protected processor?: TrackProcessor<this['kind']>;

protected processorLock: Mutex;

Expand Down Expand Up @@ -402,10 +402,7 @@ export default abstract class LocalTrack extends Track {
* @param showProcessedStreamLocally
* @returns
*/
async setProcessor(
processor: TrackProcessor<typeof this.kind>,
showProcessedStreamLocally = true,
) {
async setProcessor(processor: TrackProcessor<this['kind']>, showProcessedStreamLocally = true) {
const unlock = await this.processorLock.lock();
try {
log.debug('setting up processor');
Expand Down
Loading