Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace yarn with pnpm #926

Merged
merged 7 commits into from
Nov 8, 2023
Merged

Replace yarn with pnpm #926

merged 7 commits into from
Nov 8, 2023

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Nov 7, 2023

CI is failing due to a previously swallowed type error on main branch.
This error only surfaced with the pnpm switch. It's fixed in this branch already, but the size-limit action also tries to build main with the same config as in this branch, which then fails.

Copy link

changeset-bot bot commented Nov 7, 2023

⚠️ No Changeset found

Latest commit: dc1ce5e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 7, 2023

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 77.14 KB (0%)
dist/livekit-client.umd.js 82.68 KB (0%)

@lukasIO lukasIO marked this pull request as ready for review November 8, 2023 08:04
@lukasIO lukasIO requested review from davidzhao and Ocupe November 8, 2023 08:06
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good bye 🧶

Copy link
Contributor

@Ocupe Ocupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lukasIO lukasIO merged commit 5bdcf36 into main Nov 8, 2023
2 checks passed
@lukasIO lukasIO deleted the pnpm branch November 8, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants