Use single state var to track connection state of signal client #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7b0ea45 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
davidzhao
approved these changes
Nov 30, 2023
| @@ -1129,7 +1130,7 @@ export default class LocalParticipant extends Participant { | |||
| ) { | |||
| this.participantTrackPermissions = participantTrackPermissions; | |||
| this.allParticipantsAllowedToSubscribe = allParticipantsAllowed; | |||
| if (this.engine.client.isConnected) { | |||
| if (this.engine.client.currentState < SignalConnectionState.DISCONNECTING) { | |||
There was a problem hiding this comment.
it'd be better to abstract the enum math under something like a get isDisconnected():boolean
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously we had
isConnectingandisReconnectingas two boolean values, with the possibility to create ambigious states.This PR instead uses a singe
SignalConnectionStateto track the current signal client connection status.(hide whitespace recommended for review)