Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for async room sid #983

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Add support for async room sid #983

merged 3 commits into from
Jan 10, 2024

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Jan 3, 2024 •
edited
Loading

Removes room.sid and replaces it with await room.getSid().

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 3, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: a3f0367

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2024 •
edited
Loading

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 78.86 KB (+0.11% 🔺)
dist/livekit-client.umd.js 84.45 KB (+0.1% 🔺)

@lukasIO lukasIO added the v2 label Jan 3, 2024
@lukasIO lukasIO requested a review from davidzhao January 10, 2024 10:31
davidzhao
davidzhao approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lukasIO lukasIO merged commit 37aaf4f into main Jan 10, 2024
3 checks passed
@lukasIO lukasIO deleted the lukas/async-room-id branch January 10, 2024 17:13
@github-actions github-actions bot mentioned this pull request Jan 10, 2024
Merged
@davidzhao davidzhao mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

Assignees
No one assigned
Labels
v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasIO @davidzhao