Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remote unpublish #997

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Fix remote unpublish #997

merged 1 commit into from
Jan 18, 2024

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Jan 17, 2024 •
edited
Loading

When refactoring the SignalClient, I forgot to emit the trackUnpublished event from the engine.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 17, 2024

⚠️ No Changeset found

Latest commit: 1226c2f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 80.6 KB (+0.02% 🔺)
dist/livekit-client.umd.js 86.21 KB (+0.02% 🔺)

@lukasIO lukasIO requested a review from davidzhao January 17, 2024 15:35
@lukasIO lukasIO merged commit 98fa5eb into main Jan 18, 2024
3 checks passed
@lukasIO lukasIO deleted the lukas/fix-handling-unpublish-response branch January 18, 2024 07:50
lukasIO added a commit that referenced this pull request Jan 18, 2024
@lukasIO
Fix remote unpublish (#997)
832bfd2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasIO @davidzhao