Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backup storage options #792

Merged
merged 7 commits into from
Oct 16, 2024
Merged

backup storage options #792

merged 7 commits into from
Oct 16, 2024

Conversation

frostbyte73
Copy link
Member

No description provided.

@frostbyte73 frostbyte73 requested a review from a team as a code owner October 15, 2024 21:33
biglittlebigben
biglittlebigben approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@biglittlebigben biglittlebigben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we send a webhook with the filename for each file that was sent to the backup destination?

@frostbyte73
Copy link
Member Author

LGTM. Should we send a webhook with the filename for each file that was sent to the backup destination?

We'll have to do something with cloud-egress/cloud-io and generate presigned download urls

@frostbyte73
Copy link
Member Author

Still need to figure out what to do about situations like some segments or images going to backup while the rest go to primary

@frostbyte73 frostbyte73 merged commit d0629ce into main Oct 16, 2024
8 checks passed
@frostbyte73 frostbyte73 deleted the upload-backups branch October 16, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biglittlebigben biglittlebigben biglittlebigben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frostbyte73 @biglittlebigben