fixed ffi build for android. #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudwebrtc
force-pushed
the
duan/fix-build-for-android
branch
from
8554627 to
1fd3af7
Compare
cloudwebrtc
force-pushed
the
duan/fix-build-for-android
branch
from
1fd3af7 to
c60d376
Compare
cloudwebrtc
force-pushed
the
duan/fix-build-for-android
branch
from
c80764a to
f08119e
Compare
cloudwebrtc
changed the title
nbsp
approved these changes
Nov 28, 2024
| @@ -85,5 +88,6 @@ jobs: | |||
| - name: Build (Android) | |||
| if: ${{ contains(matrix.target, 'android') }} | |||
| run: | | |||
| ln -sf $ANDROID_NDK_ROOT/toolchains/llvm/prebuilt/linux-x86_64/lib/${{ matrix.ndk_arch }}/{libunwind.so,libc++abi.a} $ANDROID_NDK_ROOT/toolchains/llvm/prebuilt/linux-x86_64/lib/ | |||
There was a problem hiding this comment.
is there an envvar we can set instead of symlinking these?
There was a problem hiding this comment.
When using ndk r25 above, this error will appear, but I can't find the real reason for it. It may be a bug in cargo ndk when linking libunwind. I observed the directory structure in ndk r27 and found that the libunwind.so symbolic link corresponds to x86_64-unknown-linux-musl/libunwind.so by default, but this is obviously a mistake for aarch64 and armv7 compilation. I guess I should see if there is any issue/patch in the cargo-ndk upstream (our repo does not directly depend on unwind related packages).
theomonnom
approved these changes
Nov 30, 2024
mikayla-maki
pushed a commit
to zed-industries/livekit-rust-sdks
that referenced
this pull request
Dec 2, 2024
fixed ffi build for android.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed compilation for android ffi
https://github.com/livekit/rust-sdks/actions/runs/12062288204