Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataStream sending support and recv fixes #533

Merged
merged 12 commits into from
Jan 8, 2025
Merged

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Dec 20, 2024

Adds support for sending DataStreamHeader and DataStreamChunk via FFI.

Introduces publish_raw_data to allow for sending of non-user packets without having to expose explicit APIs on the room (as it's currently only used by FFI and we can thus decide on a rust level API for sending data streams later)

Adds participant_identity to received data stream messages

Copy link
Contributor

ilo-nanpa bot commented Dec 20, 2024

it seems like you haven't added any nanpa changeset files to this PR.

if this pull request includes changes to code, make sure to add a changeset, by writing a file to .nanpa/<unique-name>.kdl:

minor type="added" "Introduce frobnication algorithm"

refer to the manpage for more information.

@lukasIO lukasIO requested review from theomonnom and nbsp December 20, 2024 10:48
@lukasIO lukasIO marked this pull request as draft December 20, 2024 11:14
@lukasIO lukasIO marked this pull request as ready for review December 20, 2024 11:51
@lukasIO lukasIO requested a review from davidzhao December 20, 2024 11:55
@lukasIO lukasIO requested a review from bcherry January 6, 2025 14:56
@lukasIO lukasIO merged commit 5047dae into main Jan 8, 2025
11 of 16 checks passed
@lukasIO lukasIO deleted the lukas/data-stream-send branch January 8, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants