-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clipping: search for first and last segments to clip #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emranemran
changed the title
wip: clipping support
add clipping support for vod + live + recordings
Jul 28, 2023
thomshutt
reviewed
Jul 28, 2023
emranemran
changed the title
add clipping support for vod + live + recordings
clipping: search for first and last segments to clip
Aug 2, 2023
Codecov Report
@@ Coverage Diff @@
## main #777 +/- ##
===================================================
+ Coverage 58.19323% 58.30162% +0.10839%
===================================================
Files 58 59 +1
Lines 4937 4993 +56
===================================================
+ Hits 2873 2911 +38
- Misses 1843 1855 +12
- Partials 221 227 +6
Continue to review full report in Codecov by Sentry.
|
thomshutt
reviewed
Aug 3, 2023
emranemran
force-pushed
the
emran/clips
branch
2 times, most recently
from
August 3, 2023 23:36
1f84f28
to
f8ee3b2
Compare
mjh1
reviewed
Aug 4, 2023
Updates:
Pls re-review @thomshutt @mjh1 |
emranemran
force-pushed
the
emran/clips
branch
4 times, most recently
from
August 7, 2023 14:08
93c93ca
to
fed2232
Compare
mjh1
reviewed
Aug 7, 2023
mjh1
reviewed
Aug 7, 2023
ClipManifest takes a manifest and the start/end clip times and returns MediaSegments that correspond to those times.
mjh1
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 in series of Clipping related PRs.
This change adds methods to take any HLS manifest and return the start and end segments that correspond to the specified clipping timestamps.