Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retries seemed to be causing zero byte files #40

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Nov 2, 2023

Need to save the contents of the input so that retries won't end up reading from an empty reader.

Need to save the contents of the input so that retries won't end up reading from an empty reader.
@mjh1 mjh1 requested review from thomshutt and leszko November 2, 2023 10:51
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #40 (6879e76) into main (7d4f20b) will decrease coverage by 0.60108%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main         #40         +/-   ##
===================================================
- Coverage   16.12903%   15.52795%   -0.60108%     
===================================================
  Files              2           2                 
  Lines            155         161          +6     
===================================================
  Hits              25          25                 
- Misses           121         127          +6     
  Partials           9           9                 
Files Coverage Δ
core/uploader.go 20.00000% <0.00000%> (-1.00840%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d4f20b...6879e76. Read the comment docs.

Files Coverage Δ
core/uploader.go 20.00000% <0.00000%> (-1.00840%) ⬇️

@mjh1 mjh1 merged commit f21e006 into main Nov 2, 2023
10 checks passed
@mjh1 mjh1 deleted the mh/fix-retries branch November 2, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants