Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump ffmpeg thumbnail timeout #44

Merged
merged 1 commit into from
Nov 14, 2023
+1 −1
Merged

bump ffmpeg thumbnail timeout #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/uploader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@
outFile,
}

timeout, cancel := context.WithTimeout(context.Background(), 5*time.Second)
timeout, cancel := context.WithTimeout(context.Background(), 8*time.Second)

Check warning on line 150 in core/uploader.go

View check run for this annotation

Codecov / codecov/patch

core/uploader.go#L150 

Added line #L150 was not covered by tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of bytes.Buffer we might need to use cmd.StdoutPipe() and cmd.StderrPipe() https://stackoverflow.com/questions/35994907/go-combining-cmd-stdoutpipe-and-cmd-stderrpipe instead

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or cmd.CombinedOutput()

defer cancel()
cmd := exec.CommandContext(timeout, "ffmpeg", args...)

Expand Down
Loading