Revert "Bump recording object ttl to 10 days (#45)" #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 549ad12. We should use the option on the access keys instead, and then remove this hack.
hjpotter92
approved these changes
Nov 29, 2023
| @@ -46,7 +46,7 @@ func Upload(input io.Reader, outputURI string, waitBetweenWrites, writeTimeout t | |||
| if strings.Contains(outputURI, "gateway.storjshare.io/catalyst-recordings-com") { | |||
| fields = &drivers.FileProperties{ | |||
| Metadata: map[string]string{ | |||
| "Object-Expires": "+240h", // Objects will be deleted after 10 days | |||
| "Object-Expires": "+168h", // Objects will be deleted after 7 days | |||
There was a problem hiding this comment.
Why do we expire recordings after 7 days?
Are these some intermediate source files?
There was a problem hiding this comment.
Exactly yep, we ingest recordings from them and then they're no longer needed.
pwilczynskiclearcode
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 549ad12.
We should use the option on the access keys instead, and then remove this hack.