Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add success logs back in #53

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Add success logs back in #53

merged 1 commit into from
Jan 26, 2024

Conversation

thomshutt
Copy link
Contributor

These are actually quite useful for reasoning about recording behaviour

@thomshutt thomshutt requested a review from mjh1 January 26, 2024 15:59
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (803ed70) 17.57576% compared to head (55034a7) 17.68293%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main         #53         +/-   ##
===================================================
+ Coverage   17.57576%   17.68293%   +0.10717%     
===================================================
  Files              2           2                 
  Lines            165         164          -1     
===================================================
  Hits              29          29                 
+ Misses           128         127          -1     
  Partials           8           8                 
Files Coverage Δ
catalyst-uploader.go 0.00000% <0.00000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 803ed70...55034a7. Read the comment docs.

Files Coverage Δ
catalyst-uploader.go 0.00000% <0.00000%> (ø)

@thomshutt thomshutt merged commit fd91c08 into main Jan 26, 2024
9 checks passed
@thomshutt thomshutt deleted the success-logs branch January 26, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants