Emran/debug test failure #2818
Closed
Emran/debug test failure #2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The O community has shown interest in B introspection where some logging can be published to a public facing Loki instance that can be used to debug the selection algorithm. To that end, this change adds a few methods to the clog package to publish logs with a specific tag ([PublicLogs]) and removes any contextual info that should not be published. To log specific lines to the public facing Loki instance, one can do the following as an example: - clog.PublicInfof(ctx, "Updating O ID=%v, reason=%v", "fooID", "bar") The resulting log will have specific contextual info like manifestID, orchSessionID, etc pre-pended along with a [PublicLogs] tag.
Codecov Report
@@ Coverage Diff @@
## master #2818 +/- ##
===================================================
+ Coverage 56.62789% 56.84106% +0.21317%
===================================================
Files 88 88
Lines 19086 19171 +85
===================================================
+ Hits 10808 10897 +89
+ Misses 7684 7679 -5
- Partials 594 595 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this to debug CI failures - will not merge