Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter to force HW Session Reinit #2882

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Oct 5, 2023

Add a possibility to request HW Session Reinit by adding a transcode parameter:

{"forceSessionReinit":true}

The context for this change is that if the encoding or resolution of a segment has changed, then the HW session needs a restart. Otherwise, we see quality issues in all the following segments.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #2882 (b85dbcb) into master (fad5837) will decrease coverage by 0.03268%.
The diff coverage is 29.62963%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2882         +/-   ##
===================================================
- Coverage   56.40523%   56.37255%   -0.03268%     
===================================================
  Files             89          89                 
  Lines          19367       19380         +13     
===================================================
+ Hits           10924       10925          +1     
- Misses          7839        7849         +10     
- Partials         604         606          +2     
Files Coverage Δ
server/broadcast.go 77.55776% <ø> (ø)
server/rpc.go 72.10682% <100.00000%> (+0.08301%) ⬆️
core/transcoder.go 34.45596% <0.00000%> (ø)
server/mediaserver.go 67.20183% <57.14286%> (-0.15449%) ⬇️
core/streamdata.go 48.27586% <0.00000%> (-0.84695%) ⬇️
core/lb.go 76.96629% <0.00000%> (-3.15067%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fad5837...b85dbcb. Read the comment docs.

Files Coverage Δ
server/broadcast.go 77.55776% <ø> (ø)
server/rpc.go 72.10682% <100.00000%> (+0.08301%) ⬆️
core/transcoder.go 34.45596% <0.00000%> (ø)
server/mediaserver.go 67.20183% <57.14286%> (-0.15449%) ⬇️
core/streamdata.go 48.27586% <0.00000%> (-0.84695%) ⬇️
core/lb.go 76.96629% <0.00000%> (-3.15067%) ⬇️

@leszko leszko marked this pull request as ready for review October 6, 2023 10:52
@leszko leszko merged commit aa79cf5 into master Oct 6, 2023
18 checks passed
@leszko leszko deleted the rafal/reinit-hw-session branch October 6, 2023 12:00
eliteprox pushed a commit to eliteprox/go-livepeer that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants