Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a metric tag for Orchestrator version #3158

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Sep 2, 2024

What does this pull request do? Explain your changes. (required)

Added a metric tag for Orchestrator versions so that we can easily track the versions in use on the network as we are interacting with the O's.

How did you test each of these updates (required)

Tested on our staging environment

Does this pull request close any open issues?

Checklist:

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.34261%. Comparing base (eb2463f) to head (c7f1625).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
monitor/census.go 66.66667% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3158         +/-   ##
===================================================
- Coverage   57.34447%   57.34261%   -0.00186%     
===================================================
  Files             92          92                 
  Lines          15801       15805          +4     
===================================================
+ Hits            9061        9063          +2     
- Misses          6136        6137          +1     
- Partials         604         605          +1     
Files with missing lines Coverage Δ
monitor/census.go 66.29423% <66.66667%> (-0.06091%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb2463f...c7f1625. Read the comment docs.

Files with missing lines Coverage Δ
monitor/census.go 66.29423% <66.66667%> (-0.06091%) ⬇️

@mjh1 mjh1 merged commit 2e55134 into master Sep 2, 2024
19 checks passed
@mjh1 mjh1 deleted the mh/orch-version-tag branch September 2, 2024 15:44
@j0sh j0sh mentioned this pull request Sep 9, 2024
5 tasks
@pwilczynskiclearcode
Copy link
Contributor

@mjh1 @leszko
Any idea how to introduce orchestrator_version key/label to ai-video metrics?

@leszko
Copy link
Contributor

leszko commented Sep 25, 2024

orchestrator_version

I think we need to:

  • merge master into ai-video => I guess it's done by Rick (9c20ce8)
  • deploy ai-gateway to prod

@pwilczynskiclearcode
Copy link
Contributor

pwilczynskiclearcode commented Sep 26, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants