Clean up inactive sessions #3163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not cleaning up the sessions causes quite a big memory leak which in effect causes OOMKilled
|
The broadcaster has its own media session timeout right? Could that be tied to the PM session? Just wondering, no real opinion on the PR ... as long as the sessions timeout for media/pm are somewhat synced, the approach seems fine 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not cleaning up the sessions causes quite a big memory leak which in effect causes OOMKilled
fix https://linear.app/livepeer/issue/PS-726/5xx-broadcasters-alerts-prod-livepeer-broadcaster-08gow