Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broadcaster: Fix video compatibility check #3164

Merged
merged 2 commits into from
Sep 9, 2024
Merged

broadcaster: Fix video compatibility check #3164

merged 2 commits into from
Sep 9, 2024

Conversation

j0sh
Copy link
Collaborator

@j0sh j0sh commented Sep 6, 2024

What does this pull request do? Explain your changes. (required)

Fixes video compatibility check that led to excessive transcoder re-initialization.

Not all fields will be identical segment-to-segment, particularly DurationSecs.
This caused unnecessary transcoder re-initialization.

Specific updates (required)

  • Add a videoCompatible helper to check for video compatibility
  • Add unit tests for the videoCompatible helper

How did you test each of these updates (required)

  1. Unit tests for the helper
  2. Manual testing to ensure transcoding session gets reused

Does this pull request close any open issues?

Checklist:

Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good finding @j0sh 🏅

@j0sh
Copy link
Collaborator Author

j0sh commented Sep 6, 2024

Added a check for the audio codec too, just to be safe - 6016b9b

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.36772%. Comparing base (48a92a1) to head (c046e6f).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3164         +/-   ##
===================================================
+ Coverage   57.35155%   57.36772%   +0.01617%     
===================================================
  Files             92          92                 
  Lines          15813       15819          +6     
===================================================
+ Hits            9069        9075          +6     
  Misses          6139        6139                 
  Partials         605         605                 
Files with missing lines Coverage Δ
server/mediaserver.go 67.71429% <100.00000%> (+0.18555%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48a92a1...c046e6f. Read the comment docs.

Files with missing lines Coverage Δ
server/mediaserver.go 67.71429% <100.00000%> (+0.18555%) ⬆️

Not all fields will be identical segment-to-segment,
particularly DurationSecs. This caused unnecessary
transcoder re-initialization.
@j0sh j0sh merged commit a99a631 into master Sep 9, 2024
18 checks passed
@j0sh j0sh deleted the ja/fix-media-check branch September 9, 2024 17:59
@j0sh j0sh mentioned this pull request Sep 9, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants