Livepool llm rebase #3178
Closed
Livepool llm rebase #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad-astra-video
force-pushed
the
livepool-llm-rebase
branch
from
dac792f
to
2095440
Compare
ad-astra-video
force-pushed
the
livepool-llm-rebase
branch
from
2095440
to
a3d7462
Compare
5 tasks
rickstaa
reviewed
Sep 22, 2024
| @@ -23,6 +23,7 @@ type AI interface { | |||
| Upscale(context.Context, worker.GenUpscaleMultipartRequestBody) (*worker.ImageResponse, error) | |||
| AudioToText(context.Context, worker.GenAudioToTextMultipartRequestBody) (*worker.TextResponse, error) | |||
| SegmentAnything2(context.Context, worker.GenSegmentAnything2MultipartRequestBody) (*worker.MasksResponse, error) | |||
| LlmGenerate(context.Context, worker.GenLlmFormdataRequestBody) (interface{}, error) | |||
There was a problem hiding this comment.
@kyriediculous, @ad-astra-video can we rename this to LLMGenerate?
rickstaa
reviewed
Sep 23, 2024
| line := scanner.Text() | ||
| if strings.HasPrefix(line, "data: ") { | ||
| data := strings.TrimPrefix(line, "data: ") | ||
| if data == "[DONE]" { |
There was a problem hiding this comment.
@kyriediculous why do we need both status DONE and a done boolean?
There was a problem hiding this comment.
Per discord message, SSE streams end with a [DONE] message. This comment can be addressed in update to Livepool LLM PR.
|
Closing, Livepool LLM PR will be used to take this across the finish line. This PR was created to hopefully save some time on the updates needed to get there since I had to make these changes to test the pipeline end-to-end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Rebases Livepool LLM PR
Specific updates (required)
How did you test each of these updates (required)
stream=falseandstream=truecurl -N -X POST http://127.0.0.1:6666/llm-generate -F "prompt=tell me a story about Mario taking a beach vacation" -F "model_id=meta-llama/Meta-Llama-3.1-8B-Instruct" -F max_tokens=256 -F stream=trueDoes this pull request close any open issues?
Checklist:
makeruns successfully./test.shpass