Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: feat(rewardService): add reward call retries #3206

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rickstaa
Copy link
Member

@rickstaa rickstaa commented Oct 15, 2024

This commit adds logic to retry reward calls if they fail. The retry mechanism can be enabled by setting the rewardRetryInterval to a value greater than 0. If rewardRetryInterval is set to 0, retries are disabled, and the reward call is attempted only once.

What does this pull request do? Explain your changes. (required)

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

TODOS

  • Update docs.
  • Add tests.
  • Check racing conditions.

Checklist:

@rickstaa rickstaa marked this pull request as draft October 15, 2024 07:43
@rickstaa rickstaa changed the title feat(rewardService): add reward call retries POC: feat(rewardService): add reward call retries Oct 15, 2024
@rickstaa
Copy link
Member Author

Just me doing some experimentation.

@rickstaa rickstaa force-pushed the add_reward_call_retries branch 3 times, most recently from 823b0a0 to accf696 Compare October 15, 2024 08:03
This commit adds logic to retry reward calls if they fail. The retry mechanism
can be enabled by setting the `rewardRetryInterval` to a value greater than 0.
If `rewardRetryInterval` is set to 0, retries are disabled, and the reward call
is attempted only once.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant