Fix parsing "warm" field in ParseAIModelConfigs #3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j0sh
force-pushed
the
ja/fix-model-config-parser
branch
from
4c99840
to
a512565
Compare
leszko
approved these changes
Oct 21, 2024
rickstaa
force-pushed
the
ja/fix-model-config-parser
branch
from
a512565
to
c7e49b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Fixes an off-by-one error when parsing the "warm" field when manually configuring AI pipelines via CLI flags. Also adds unit tests for this function.
Specific updates (required)
How did you test each of these updates (required)
Unit tests, manual testing
Does this pull request close any open issues?
Checklist:
makeruns successfully./test.shpass