Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ai): ensure seperate I2V transcoding timeout #3219

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

rickstaa
Copy link
Member

What does this pull request do? Explain your changes. (required)

This commit ensures a seperate I2V transcoding timeout. It also cleansup
the codebase a bit.

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

@github-actions github-actions bot added the AI Issues and PR related to the AI-video branch. label Oct 22, 2024
This commit ensures a seperate I2V transcoding timeout. It also cleansup
the codebase a bit.
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 36.08044%. Comparing base (e94b188) to head (91e4d9f).
Report is 12 commits behind head on ai-video.

Files with missing lines Patch % Lines
core/ai_worker.go 0.00000% 2 Missing ⚠️
cmd/livepeer/starter/starter.go 0.00000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##            ai-video       #3219          +/-   ##
====================================================
- Coverage   50.82671%   36.08044%   -14.74627%     
====================================================
  Files            100         124          +24     
  Lines          23769       34509       +10740     
====================================================
+ Hits           12081       12451         +370     
- Misses         11018       21370       +10352     
- Partials         670         688          +18     
Files with missing lines Coverage Δ
common/util.go 54.12541% <100.00000%> (-0.59772%) ⬇️
monitor/census.go 61.78046% <ø> (+0.20608%) ⬆️
cmd/livepeer/starter/starter.go 7.78715% <0.00000%> (ø)
core/ai_worker.go 35.64494% <0.00000%> (+0.63132%) ⬆️

... and 25 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff1f517...91e4d9f. Read the comment docs.

Files with missing lines Coverage Δ
common/util.go 54.12541% <100.00000%> (-0.59772%) ⬇️
monitor/census.go 61.78046% <ø> (+0.20608%) ⬆️
cmd/livepeer/starter/starter.go 7.78715% <0.00000%> (ø)
core/ai_worker.go 35.64494% <0.00000%> (+0.63132%) ⬆️

... and 25 files with indirect coverage changes

@rickstaa rickstaa merged commit 46a23fb into ai-video Oct 23, 2024
15 checks passed
@rickstaa rickstaa deleted the ai-video-worker-improvements branch October 23, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Issues and PR related to the AI-video branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants