Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ai): delete I2V temp file on combined Orch/worker #3234

Merged

Conversation

ad-astra-video
Copy link
Collaborator

What does this pull request do? Explain your changes. (required)

Delete temp file when using combined orchestrator/ai-worker.

Specific updates (required)

  • add defer os.Remove(image.Url) to saveLocalAIWorkerResults function when reading local file.

How did you test each of these updates (required)

Ran ai tests and tested locally

Does this pull request close any open issues?

Checklist:

@github-actions github-actions bot added the AI Issues and PR related to the AI-video branch. label Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 35.78815%. Comparing base (1a45880) to head (2d11acc).
Report is 3 commits behind head on ai-video.

Files with missing lines Patch % Lines
core/ai_worker.go 0.00000% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##            ai-video       #3234         +/-   ##
===================================================
- Coverage   35.79019%   35.78815%   -0.00204%     
===================================================
  Files            125         125                 
  Lines          35099       35101          +2     
===================================================
  Hits           12562       12562                 
- Misses         21831       21833          +2     
  Partials         706         706                 
Files with missing lines Coverage Δ
core/ai_worker.go 32.08020% <0.00000%> (-0.08060%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a45880...2d11acc. Read the comment docs.

Files with missing lines Coverage Δ
core/ai_worker.go 32.08020% <0.00000%> (-0.08060%) ⬇️

@rickstaa rickstaa merged commit b0591a4 into livepeer:ai-video Nov 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Issues and PR related to the AI-video branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants