Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix PR labeler #3254

Merged
merged 3 commits into from
Nov 18, 2024
Merged

ci: fix PR labeler #3254

merged 3 commits into from
Nov 18, 2024

Conversation

rickstaa
Copy link
Member

@rickstaa rickstaa commented Nov 15, 2024

What does this pull request do? Explain your changes. (required)

This pull request ensures that the PR labeler action is working as expected again.

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

This commit ensures that the PR labeler action is working as expected
again.
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.70278%. Comparing base (d14d2cf) to head (e40fb88).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3254         +/-   ##
===================================================
- Coverage   34.70842%   34.70278%   -0.00564%     
===================================================
  Files            136         136                 
  Lines          36216       36219          +3     
===================================================
- Hits           12570       12569          -1     
- Misses         22934       22938          +4     
  Partials         712         712                 

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9127cce...e40fb88. Read the comment docs.

see 2 files with indirect coverage changes

---- 🚨 Try these New Features:

@j0sh
Copy link
Collaborator

j0sh commented Nov 15, 2024

does this fix work?

image

@rickstaa
Copy link
Member Author

@j0sh, @leszko thanks for your review. I see I made one typo in the labels but appart from that it should work. Will fix today 👍🏻.

This commit ensures that we use the labeler config format that was
introduced in v5.
@rickstaa
Copy link
Member Author

@leszko sorry for the noise I didn't want to create a workflow trigger so just opened new pull request to test the changes. You can see it working here.

@rickstaa rickstaa merged commit 6a8fa52 into master Nov 18, 2024
18 checks passed
@rickstaa rickstaa deleted the fix_labeler branch November 18, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants