Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix startup nil pointer introduced in 9127ccee42ebb4f2f7dd09c707583c53464f134c #3260

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Fix startup nil pointer introduced in 9127ccee42ebb4f2f7dd09c707583c53464f134c #3260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cmd/livepeer/starter/starter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,12 @@
case core.BroadcasterNode:
nodeType = lpmon.Broadcaster
if *cfg.KafkaBootstrapServers != "" && *cfg.KafkaUsername != "" && *cfg.KafkaPassword != "" && *cfg.KafkaGatewayTopic != "" {
err := lpmon.InitKafkaProducer(*cfg.KafkaBootstrapServers, *cfg.KafkaUsername, *cfg.KafkaPassword, *cfg.KafkaGatewayTopic, n.Eth.Account().Address.Hex())
var broadcasterEthAddress = ""
if cfg.EthAcctAddr != nil {
broadcasterEthAddress = *cfg.EthAcctAddr
}

Check warning on line 617 in cmd/livepeer/starter/starter.go

View check run for this annotation

Codecov / codecov/patch

cmd/livepeer/starter/starter.go#L614-L617 

Added lines #L614 - L617 were not covered by tests

err := lpmon.InitKafkaProducer(*cfg.KafkaBootstrapServers, *cfg.KafkaUsername, *cfg.KafkaPassword, *cfg.KafkaGatewayTopic, broadcasterEthAddress)

Check warning on line 619 in cmd/livepeer/starter/starter.go

View check run for this annotation

Codecov / codecov/patch

cmd/livepeer/starter/starter.go#L619 

Added line #L619 was not covered by tests
if err != nil {
glog.Warning("error while initializing Kafka producer: %w", err)
}
Expand Down
Loading