Add an error return to makeStreamID to make issues explicit #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leszko
reviewed
May 13, 2024
| gotStream func(url *url.URL, rtmpStrm stream.RTMPVideoStream) error, | ||
| endStream func(url *url.URL, rtmpStrm stream.RTMPVideoStream) error) { | ||
|
|
||
| if self.RtmpServer != nil { | ||
| self.RtmpServer.HandlePublish = func(conn *joy4rtmp.Conn) { | ||
| glog.V(2).Infof("RTMP server got upstream: %v", conn.URL) | ||
|
|
||
| strmID := makeStreamID(conn.URL) | ||
| if strmID == nil || strmID.StreamID() == "" { |
There was a problem hiding this comment.
Where is this makeStreamID() actually implemented? In go-livepeer? I wonder if changing this condition here won't bring any regression.
There was a problem hiding this comment.
Yep, in go-livepeer. I think that we can probably keep the original check as well though if we'd like to be safe
leszko
approved these changes
May 13, 2024
mjh1
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow us to signal different types of errors in go-livepeer and ultimately pass back different HTTP statuses from the Broadcaster depending on the stream creation failure reason