Skip to content
Back to pull request #641

docs: add vscode note to CONTRIBUTING.md #14

Sign in to view logs

docs: add vscode note to CONTRIBUTING.md

docs: add vscode note to CONTRIBUTING.md #14

Triggered via pull request April 12, 2024 14:52
@rickstaarickstaa
opened #641
add_vscode_hardhat_contribution_note
Status Success
Total duration 9m 51s
Artifacts –

test.yaml

on: pull_request
Test with coverage
9m 42s
Test with coverage
Run editorconfig checker
4s
Run editorconfig checker
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
Test with coverage
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test with coverage: contracts/bonding/BondingManager.sol#L32
Explicitly mark visibility of state
Test with coverage: contracts/governance/Governor.sol#L91
Avoid to use low level calls
Test with coverage: contracts/ManagerProxy.sol#L54
Avoid to use inline assembly. It is acceptable only in rare cases
Test with coverage: contracts/pm/mixins/MixinTicketProcessor.sol#L82
Avoid to use inline assembly. It is acceptable only in rare cases
Test with coverage: contracts/pm/mixins/MixinWrappers.sol#L49
Avoid to use low level calls
Test with coverage: contracts/token/LivepeerToken.sol#L12
Variable name must be in mixedCase
Test with coverage: contracts/token/LivepeerToken.sol#L13
Variable name must be in mixedCase
Test with coverage: contracts/treasury/GovernorCountingOverridable.sol#L65
Function name must be in mixedCase
Test with coverage: contracts/treasury/GovernorCountingOverridable.sol#L69
Function name must be in mixedCase