test: Get to 100% test coverage #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorges
force-pushed
the
vg/fix/test-coverage
branch
from
d686a14
to
a05ac44
Compare
no idea why it started failing now, but easy fix
victorges
force-pushed
the
vg/fix/test-coverage
branch
from
a05ac44
to
04a0fa8
Compare
victorges
changed the title
victorges
force-pushed
the
vg/fix/test-coverage
branch
from
e935cbe
to
bde5baa
Compare
|
🥳 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## delta #639 +/- ##
====================================================
+ Coverage 99.61861% 100.00000% +0.38139%
====================================================
Files 29 29
Lines 1311 1311
Branches 218 218
====================================================
+ Hits 1306 1311 +5
+ Misses 5 0 -5 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This is just to get back to 100% coverage on BondingManager and Manager code by checking an unexercised code path.
Specific updates (required)
How did you test each of these updates (required)
yarn testDoes this pull request close any open issues?
No.
Checklist:
yarn testpass