api: Fix experiment schema

livepeer · Jan 18, 2023 · 525f072 · 525f072
1 parent 1881af0
commit 525f072
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/packages/api/src/controllers/experiment.ts b/packages/api/src/controllers/experiment.ts
@@ -31,8 +31,8 @@ async function toUserId(emailOrId: string) {
   return user.id;
 }
 
-const toUserIds = (emailsOrIds: string[]) =>
-  Promise.all(emailsOrIds.map(toUserId));
+const toUserIds = (emailsOrIds?: string[]) =>
+  Promise.all(emailsOrIds?.map(toUserId) ?? []);
 
 const app = Router();
 
@@ -129,7 +129,7 @@ app.patch("/:experiment", authorizer({ anyAdmin: true }), async (req, res) => {
     !Array.isArray(audienceUserIds) ||
     audienceUserIds.some((s) => typeof s !== "string")
   ) {
-    throw new BadRequestError("userIds must be an array of strings");
+    throw new BadRequestError("audienceUserIds must be an array of strings");
   }
 
   const experiment = await db.experiment.getByNameOrId(experimentQuery);
@@ -149,10 +149,10 @@ app.get("/:experiment", authorizer({ anyAdmin: true }), async (req, res) => {
   experiment = {
     ...experiment,
     audienceUsers: await Promise.all(
-      experiment.audienceUserIds.map(async (userId) => {
+      experiment.audienceUserIds?.map(async (userId) => {
         const user = await db.user.get(userId);
         return db.user.cleanWriteOnlyResponse(user);
-      })
+      }) ?? []
     ),
   };
 

diff --git a/packages/api/src/schema/schema.yaml b/packages/api/src/schema/schema.yaml
@@ -766,7 +766,6 @@ components:
     experiment-audience-payload:
       type: object
       additionalProperties: false
-      required: [type, stream]
       properties:
         addUsers:
           type: array
@@ -2334,7 +2333,7 @@ components:
       type: object
       table: experiment
       additionalProperties: false
-      required: [name, userIds]
+      required: [name]
       properties:
         type:
           type: string

diff --git a/packages/api/src/store/experiment-table.ts b/packages/api/src/store/experiment-table.ts
@@ -8,7 +8,7 @@ import { WithID } from "./types";
 
 export async function isExperimentSubject(experiment: string, userId: string) {
   const { audienceUserIds } = await db.experiment.getByNameOrId(experiment);
-  return audienceUserIds.includes(userId);
+  return audienceUserIds?.includes(userId) ?? false;
 }
 
 export async function ensureExperimentSubject(