-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating June tracking tool #2126
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove additional instances of Ripe:
import Ripe, { categories, pages } from "lib/ripe"; |
Ripe.trackPage({ |
useEffect(() => { |
studio/packages/www/pages/index.tsx
Line 10 in 6432cc9
import Ripe, { categories, pages } from "lib/ripe"; |
Also need to remove ripe.js file:
packages/www/components/StreamDetails/MultistreamTargetsTable/index.tsx
Outdated
Show resolved
Hide resolved
When I navigate to a stream detail view and then refresh the page I get an error that |
@adamsoffer I wonder if the |
hey @hthillman
cc: @adamsoffer |
Also, the big "file changes" are just types issue related to livepeer/design library which is also fixed |
useEffect(() => { | ||
const loadAnalytics = async () => { | ||
let response = AnalyticsBrowser.load({ | ||
writeKey: "3VINzqYVjfOxFyIr", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, if this needs to be added to .env
. Please feel free to move it from here if it needs to kept private.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @suhailkakar !
This tool allows us to track users through their onboarding journey.
Testing instructions:
**note: I've disabled the
identifyUser
step for staging, so you'll need to run locally - you can also use the preview from 3860bc8 if you want but probably better to run locally **We will need to check functionality of everywhere I've added June events.
I've also ripped out the Ripe integration points for now, can revert if needed