Add pullRegion to streams to make the ingest node sticky #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leszko
changed the title
emranemran
reviewed
Apr 12, 2024
| @@ -712,6 +713,28 @@ describe("controllers/stream", () => { | |||
| const document = await db.stream.get(stream.id); | |||
| expect(db.stream.addDefaultFields(document)).toEqual(updatedStream); | |||
| }); | |||
| it("should extract region from redirected playback url", async () => { | |||
There was a problem hiding this comment.
It might be good to have some flv urls in here to verify nothing breaks:
e.g /flv/<playback-id>
There was a problem hiding this comment.
As pointed out below, we don't use it for /flv
| return null; | ||
| } | ||
| const url = new URL( | ||
| pathJoin(ingest, `hls`, "not-used-playback", `index.m3u8`) |
There was a problem hiding this comment.
don't we need to handle flv as well?
There was a problem hiding this comment.
No, this call is not for the "any redirect", this is just to discover which should be the ingest node.
So, kind-of hack the system and use catalyst-api redirect balancing (effectively using MistUtilLoad) to divide on the ingest node.
emranemran
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the updated flow:
stream.pull.location)stream.pullRegionThis way, we resolve region once in
/pulland then re-use the same region for stream pulling. This should make some improvement in the ingest node, and what's even better, we can start logging that(lat,lon)=>region, and then have data to say if out method for choosing ingest node (MistUtilLoad) is correct.One of the further idea would be to not use
MistUtilLoad, but just always use the geographically closest node.Related PRs: