Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new usage charts #2293

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat: new usage charts #2293

wants to merge 7 commits into from

Conversation

suhailkakar
Copy link
Member

What does this pull request do? Explain your changes. (required)

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Screenshots (optional)

Checklist

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@suhailkakar suhailkakar requested a review from a team as a code owner August 18, 2024 09:17
Copy link

vercel bot commented Aug 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2024 9:30am

@0xcadams
Copy link
Contributor

It looks like prettier is failing on this

@suhailkakar
Copy link
Member Author

Let's wait for the redesign pr (#2298) to get merged and then we can merge this so both are same design and colors


const nestLabel = payload.length === 1 && indicator !== "dot";
const formatValue = (value) => {
if (value >= 1000) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be better to update it with value >= 100.
so that it can show 0.9k instead of 952 for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants