Add surname to registration form #2313
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I think we'll actually need to do something with this value here. Where do they want it to go? Hubspot? |
|
@0xcadams Yep, Hubspot - from the last time I used this page, I thought all values from the form got passed through to Hubspot by default |
| @@ -123,6 +124,20 @@ const Register = ({ id, buttonText, onSubmit, loading, errors }) => { | |||
| onChange={(e) => setFirstName(e.target.value)} | |||
| /> | |||
|
|
|||
| <TextField | |||
There was a problem hiding this comment.
Does this already go magically on the request sent to backend? I think it's called lastName on the API https://github.com/livepeer/livepeer-com/blob/4e24f8e656e204089b0d0057428820045c162c89/packages/api/src/controllers/user.ts#L314
There was a problem hiding this comment.
@victorges good call, you were right - I updated it (it's lastName in Hubspot too) and tested locally the the last name makes it into the DB and Hubspot
At the request of Marketing, this PR adds an explicit surname field to the registration form.