Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ai: generate: remove endpoint from experiment & remove beta from path #2318

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

gioelecerati
Copy link
Member

What does this pull request do? Explain your changes. (required)

  • Remove generate from experiment
  • Remove beta from path
  • Make sure that the endpoint still works with the deprecated beta, to be removed on a second time for a full phase out
  • Modified the tests to test both the new and the beta paths

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Screenshots (optional)

Checklist

  • [ X] I have read the CONTRIBUTING document.
  • [ X] My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ X] I have added tests to cover my changes.

@gioelecerati gioelecerati requested a review from a team as a code owner October 1, 2024 11:05
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 2:06pm

Comment on lines +74 to +82
const testBothRoutes = (testFn) => {
describe("generate route", () => {
testFn("/generate");
});

describe("beta generate route", () => {
testFn("/beta/generate");
});
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind we need to update CloudFlare routes to also skip the regular worker on the new route.

packages/api/src/controllers/generate.test.ts Show resolved Hide resolved
packages/api/src/controllers/generate.ts Outdated Show resolved Hide resolved
packages/api/src/controllers/generate.ts Show resolved Hide resolved
packages/api/src/schema/pull-ai-schema.js Outdated Show resolved Hide resolved
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -368,6 +368,65 @@ paths:
schema:
$ref: '#/components/schemas/studio-api-error'
x-speakeasy-name-override: segmentAnything2
/api/generate/llm:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind you might have conflict with @mjh1's #2319, but it should be solved by simply running the pull-ai-schema script again

@gioelecerati gioelecerati merged commit af93493 into master Oct 3, 2024
8 checks passed
@gioelecerati gioelecerati deleted the gio/generate/remove-beta branch October 3, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants