Put hack in place for StreamETH to do 20 concurrent clips instead of 5 #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gioelecerati
approved these changes
Nov 7, 2024
| if (processingClips.length >= MAX_PROCESSING_CLIPS && !clippingUser.admin) { | ||
| // Hack to let StreamETH have a higher clipping limit without having to do the work to put this on the User object | ||
| let maxProcessingClips = MAX_PROCESSING_CLIPS; | ||
| if (req.user.id == "05f04681-b600-4a9b-81ea-1f56e7871f04") { |
There was a problem hiding this comment.
WDYT of checking with owner.id instead, so it's applied to the owner of the content itself and not the user owning the api key doing the request? I am fine with it either way as only admins are allowed to do cross-clips, for now
There was a problem hiding this comment.
Yeah let's leave it for now then - we can hopefully roll this back after Devcon anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have time / inclination to do the work to make this more generic