Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't reject audio-only VOD assets #213

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't reject audio-only VOD assets #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions task/probe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,6 @@ func toAssetSpec(filename string, strict bool, probeData *ffprobe.ProbeData, siz
hasAudio = hasAudio || track.Type == "audio"
spec.VideoSpec.Tracks = append(spec.VideoSpec.Tracks, track)
}
if !hasVideo {
return nil, fmt.Errorf("no video track found in file")
}
if !hasAudio && strict {
return nil, fmt.Errorf("no audio track found in file")
}
Expand Down
1 change: 0 additions & 1 deletion task/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,6 @@ func humanizeCatalystError(err error) error {
// Keeping it simple for now and returning errInvalidVideo for this
// But, should there be a separate humanized error for this?
"readpacketdata file read failed - end of file hit",
"no video track found in file",
"no pictures decoded",
"zero bytes found for source",
"invalid framerate",
Expand Down
3 changes: 0 additions & 3 deletions task/runner_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,6 @@ func TestHumanizeError(t *testing.T) {
err = NewCatalystError("foobar Failed probe/open: foobar", false)
assert.ErrorIs(humanizeError(err), errProbe)

err = NewCatalystError("no video track found in file", false)
assert.ErrorIs(humanizeError(err), errInvalidVideo)

err = NewCatalystError("job failed: Decoder closed. No pictures decoded", false)
assert.ErrorIs(humanizeError(err), errInvalidVideo)

Expand Down
Loading