Add check for nil in ipfs.NFTMetadata to avoid panic #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomshutt
approved these changes
Jul 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
===================================================
- Coverage 16.48478% 16.45642% -0.02836%
===================================================
Files 16 16
Lines 1741 1744 +3
===================================================
Hits 287 287
- Misses 1428 1431 +3
Partials 26 26
Continue to review full report in Codecov by Sentry.
|
victorges
reviewed
Jul 22, 2024
| if err != nil { | ||
| glog.Errorf("Error unpinning metadata from IPFS %v", ipfs.NFTMetadata.CID) | ||
| return err | ||
| if ipfs.NFTMetadata != nil { |
There was a problem hiding this comment.
Wow didnt remember we could have IPFS exports without NFT. Maybe some really old assets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to panic we encounter in prod.
https://eu-metrics-monitoring.livepeer.live/grafana/goto/BiMG6oXIR?orgId=1