Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add options to pass features in mutagen runner #155

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

samuelpilz
Copy link
Contributor

Fixes first part of #154.

This adds flags --features and --all-features to the runner in the same way cargo handles them.

edition = "2018"

[dev-dependencies]
mutagen = {path = "../../mutagen"}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be an optional dependency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that, but cargo responded with: "Dev-dependencies are not allowed to be optional: mutagen"

Copy link

@elichai elichai Jan 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust-lang/cargo#1596

But because it's an example I think you can move it to a regular dependency

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to consider: Mutagen would then be included when running cargo build --release --all-features. However, in the current form such call would fail.

Please note that this is an example and people will figure out how they want to use mutagen themselves. If anyone really feels strongly about this issue, I can adapt the example.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, in that case it's OK.

Interesting. I think that's a missing cargo feature.

@elichai
Copy link

elichai commented Jan 23, 2020

Nice. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants