Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMDGPU] Constrain use LiveMask by the operand's LaneMask for RP calculation. #111452

Closed
wants to merge 2 commits into from
Closed

[AMDGPU] Constrain use LiveMask by the operand's LaneMask for RP calculation. #111452

wants to merge 2 commits into from

Commits on Oct 7, 2024

  1. [AMDGPU] Constrain use LiveMask by the operand's LaneMask for RP calc… 

    …ulation.

CoAuthor: Valery Pykhtin <[email protected]>

For speculative RP queries, recede may calculate inaccurate masks for subreg uses. Previously, the calcaultion would look at any live lane for the use at the position of the MI in the LIS. This also adds lanes for any subregs which are live at but not used by the instruction. By constraining against the getSubRegIndexLaneMask for the operand's subreg, we are sure to not pick up on these extra lanes.

For current clients of recede, this is not an issue. This is because 1. the current clients do not violate the program order in the LIS, and 2. the change to RP is based on the difference between previous mask and new mask. Since current clients are not exposed to this issue, this patch is sort of NFC.

Change-Id: I63c788785b104ed88297d06e9b2b0dbc0bf6d040
    @jrbyrnes
    jrbyrnes committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    03fb122 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Document the new signature 

    Change-Id: Ibf989b53555fe686693ca01d2e63f64aed58ded7
    @jrbyrnes
    jrbyrnes committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    da20475 View commit details
    Browse the repository at this point in the history