Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an MSVC build issue. #111557

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Commits on Oct 8, 2024

  1. Fix an MSVC build issue.

    Disable the LSE files if COMPILER_RT_HAS_ASM_LSE failed as MSVC cannot
    seem to handle .S input files.
    
    ```
    [258/401] Building ASM object CMakeFiles\clang_rt.builtins-aarch64.dir\outline_atomic_helpers.dir\outline_atomic_cas1_3.S.obj
    Microsoft (R) C/C++ Optimizing Compiler Version 19.38.33135 for ARM64
    Copyright (C) Microsoft Corporation.  All rights reserved.
    
    cl : Command line warning D9035 : option 'o' has been deprecated and will be removed in a future release
    cl : Command line warning D9024 : unrecognized source file type 'S:\b\5\runtimes\builtins-aarch64-unknown-windows-msvc-bins\outline_atomic_helpers.dir\outline_atomic_cas1_3.S', object file assumed
    cl : Command line warning D9027 : source file 'S:\b\5\runtimes\builtins-aarch64-unknown-windows-msvc-bins\outline_atomic_helpers.dir\outline_atomic_cas1_3.S' ignored
    cl : Command line warning D9021 : no action performed
    ```
    hjyamauchi committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    db843d4 View commit details
    Browse the repository at this point in the history