Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mlir] add missing CMake dependency on ShardingInterface generated headers for LinalgDialect #111603

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Zhang-Zecheng
Copy link

@Zhang-Zecheng Zhang-Zecheng commented Oct 8, 2024

This fixes non-deterministic build failures.

Fixes #111527

Copy link

github-actions bot commented Oct 8, 2024

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot
Copy link
Collaborator

llvmbot commented Oct 8, 2024

@llvm/pr-subscribers-mlir-linalg

@llvm/pr-subscribers-mlir

Author: roderickzzc (Zhang-Zecheng)

Changes

Having this issue when following 'Getting started' tutorial.

#111527


Full diff: https://github.com/llvm/llvm-project/pull/111603.diff

1 Files Affected:

  • (modified) mlir/lib/Dialect/Linalg/IR/CMakeLists.txt (+1)
diff --git a/mlir/lib/Dialect/Linalg/IR/CMakeLists.txt b/mlir/lib/Dialect/Linalg/IR/CMakeLists.txt
index f1fcb22fb8d548..c949b7fdf1164a 100644
--- a/mlir/lib/Dialect/Linalg/IR/CMakeLists.txt
+++ b/mlir/lib/Dialect/Linalg/IR/CMakeLists.txt
@@ -13,6 +13,7 @@ add_mlir_dialect_library(MLIRLinalgDialect
   MLIRLinalgOpsEnumsIncGen
   MLIRLinalgOpsIncGen
   MLIRLinalgStructuredOpsIncGen
+  MLIRShardingInterface
 
   LINK_LIBS PUBLIC
   MLIRAffineDialect

@joker-eph joker-eph changed the title add DEPENDS for linalgdialect [mlir] add missing CMake dependency on ShardingInterface generated headers for LinalgDialect Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mlir: fatal error: 'mlir/Dialect/Mesh/Interfaces/ShardingInterface.h.inc' file not found
3 participants