Address PR comments

llvm · Apr 25, 2024 · c6357cb · c6357cb
1 parent 705355a
commit c6357cb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/Conversion/TorchOnnxToTorch/DefaultDomainQtoZ.cpp b/lib/Conversion/TorchOnnxToTorch/DefaultDomainQtoZ.cpp
@@ -851,6 +851,8 @@ void mlir::torch::onnx_c::populateDefaultDomainQtoZ(
         Torch::ValueTensorType resultType;
         float alpha, gamma;
         Value operand;
+        // Refer https://onnx.ai/onnx/operators/onnx__Selu.html for the default
+        // alpha and gamma values.
         if (binder.tensorOperand(operand) ||
             binder.f32FloatAttr(alpha, "alpha", 1.67326) ||
             binder.f32FloatAttr(gamma, "gamma", 1.0507) ||

diff --git a/projects/pt1/e2e_testing/xfail_sets.py b/projects/pt1/e2e_testing/xfail_sets.py
@@ -2156,8 +2156,8 @@
     "ElementwiseLog2IntModule_basic",
     "FlipModuleStaticShape_basic",
     "FlipNegativeIndexModule_basic",
-    # "HardsigmoidModule_basic",
-    # "HardsigmoidRandomModule_basic",
+    "HardsigmoidModule_basic",
+    "HardsigmoidRandomModule_basic",
     "PixelShuffleModuleStaticRank4Float32_basic",
     "ReflectionPad1dModule2dInput_Right",
     "ReflectionPad1dModule2dInput_basic",