Implement e2e support for aten.acos op #2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramiro050
approved these changes
Dec 8, 2023
Thanks for the approval @ramiro050! I have removed the conflict, but a bump of the LLVM version is necessary since the last version bump did not yet include the commit that implements the acos operator in the Math dialect. |
This depends on a change in the LLVM core repository which adds acos support to the MLIR Math dialect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also issue #2604.
The implementation requires acos support in the MLIR Math dialect. I have created the PR llvm/llvm-project#74584 to implement this. Marking this PR as a draf until the LLVM core PR gets merged.